Skip to content

Conversation

@panva
Copy link
Member

@panva panva commented Oct 15, 2024

adds openid-client (and intrinsically also oauth4webapi and oidc-provider)

This covers the Web Cryptography API and Fetch API modules.

@panva
Copy link
Member Author

panva commented Oct 15, 2024

Hard Requirements

  • Module source code must be on Github.
  • Published versions must include a tag on Github
  • The test process must be executable with only commands
  • The tests pass on supported major release lines (skipped <20 due to lack of webcrypto global)
  • The maintainers of the module remain responsive when there are problems
  • At least one module maintainer must be added to the lookup maintainers field

Soft Requirements

  • The module must be actively used by the community
  • The module must be heavily depended on
  • The module must cover unique portions of our API (WebCryptoAPI, fetch API)
  • ❓ The module fits into a key category (e.g. Testing, Streams, Monitoring, etc.)
  • The module is under the Node.js foundation Github org
  • The module is identified as an important module by a Node.js Working Group
    Procedure

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.36%. Comparing base (1cbcf4c) to head (63bb701).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1072   +/-   ##
=======================================
  Coverage   96.36%   96.36%           
=======================================
  Files          29       29           
  Lines        2203     2203           
=======================================
  Hits         2123     2123           
  Misses         80       80           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva panva force-pushed the add-openid-client branch from e50ffb9 to 4d35d31 Compare October 15, 2024 22:38
@richardlau

This comment was marked as outdated.

@panva

This comment was marked as outdated.

@panva

This comment was marked as outdated.

@panva

This comment was marked as outdated.

@panva

This comment was marked as outdated.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@panva panva force-pushed the add-openid-client branch from 2d67d09 to 63bb701 Compare January 26, 2026 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants